Skip to content

fix: prevent resize drift caused by stale props between renders #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
STRML merged 1 commit into from
Feb 28, 2026
+6 −2
Merged

fix: prevent resize drift caused by stale props between renders #255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/Resizable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,12 @@ export default class Resizable extends React.Component<Props, void> {
if (axisV === 'n') deltaY = -deltaY;

// Update w/h by the deltas. Also factor in transformScale.
let width = this.props.width + (canDragX ? deltaX / this.props.transformScale : 0);
let height = this.props.height + (canDragY ? deltaY / this.props.transformScale : 0);
// Use lastSize (if available) instead of props to avoid losing deltas
// when React can't re-render between consecutive mouse events.
const baseWidth = this.lastSize?.width ?? this.props.width;
const baseHeight = this.lastSize?.height ?? this.props.height;
let width = baseWidth + (canDragX ? deltaX / this.props.transformScale : 0);
let height = baseHeight + (canDragY ? deltaY / this.props.transformScale : 0);

// Run user-provided constraints.
[width, height] = this.runConstraints(width, height);
Expand Down
Loading