Skip to content

Comments

[v1.19] fix: Incorrect comparison logic when comparing lists#1078

Open
openshift-cherrypick-robot wants to merge 7 commits intoredhat-developer:v1.19from
openshift-cherrypick-robot:cherry-pick-1060-to-v1.19
Open

[v1.19] fix: Incorrect comparison logic when comparing lists#1078
openshift-cherrypick-robot wants to merge 7 commits intoredhat-developer:v1.19from
openshift-cherrypick-robot:cherry-pick-1060-to-v1.19

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #1060

/assign svghadi

Signed-off-by: Atif Ali <atali@redhat.com>

cleanup: remove redundant empty/nil slice checks

Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com>

improve e2e test

Signed-off-by: Atif Ali <atali@redhat.com>

Fix test failure

Signed-off-by: Atif Ali <atali@redhat.com>

Fix test failure

Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com>

trigger reconciliation via GitopsService not ArgoCD

Signed-off-by: Atif Ali <atali@redhat.com>

test debug

Signed-off-by: Atif Ali <atali@redhat.com>

fix fmt

Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com>

add configv1 to the E2E fixture to read the clusterVersion

Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Feb 23, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jopit for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Feb 23, 2026

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants