[v1.19] fix: Incorrect comparison logic when comparing lists#1078
[v1.19] fix: Incorrect comparison logic when comparing lists#1078openshift-cherrypick-robot wants to merge 7 commits intoredhat-developer:v1.19from
Conversation
Signed-off-by: Atif Ali <atali@redhat.com> cleanup: remove redundant empty/nil slice checks Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com> improve e2e test Signed-off-by: Atif Ali <atali@redhat.com> Fix test failure Signed-off-by: Atif Ali <atali@redhat.com> Fix test failure Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com> trigger reconciliation via GitopsService not ArgoCD Signed-off-by: Atif Ali <atali@redhat.com> test debug Signed-off-by: Atif Ali <atali@redhat.com> fix fmt Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com> add configv1 to the E2E fixture to read the clusterVersion Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @openshift-cherrypick-robot. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #1060
/assign svghadi