feat: use human-readable log format for local CLI commands

[bfirsh]

Coglet defaults to JSON structured logs for production (GKE/Stackdriver compatibility), but this makes local development output hard to read.

Set LOG_FORMAT=console in cog serve, cog run, cog predict, and cog train so developers see human-readable logs locally. Production is unaffected since the env var is only set by the CLI for local commands.

Before:

After:

[ask-bonk]

I'm Bonk, and I've done a quick review of your PR.

Summary: This PR adds LOG_FORMAT=console environment variable to local CLI commands (cog run, cog serve, cog predict, cog train) to display human-readable logs during development instead of JSON.

Issue Found:

In pkg/predict/predictor.go, there's a potential mutation bug. The code directly appends to runOptions.Env without making a copy first. If the caller reuses that slice elsewhere, they'll unexpectedly get the LOG_FORMAT=console variable:

// pkg/predict/predictor.go:62-63
runOptions.Env = append(runOptions.Env, "LOG_FORMAT=console")

Unlike run.go and serve.go which correctly copy envFlags first, NewPredictor modifies the passed-in runOptions.Env directly. This could cause issues if the same environment slice is used for multiple operations.

Recommendation: Follow the same pattern as run.go and serve.go - make a copy before appending:

env := make([]string, len(runOptions.Env))
copy(env, runOptions.Env)
runOptions.Env = append(env, "LOG_FORMAT=console")

This is a medium severity issue because it could cause unexpected behavior if the caller relies on the original environment slice not being modified.

The rest of the changes look good and are consistent with the stated goal.

github run

[ask-bonk]

I'm Bonk, and I've done a quick review of your PR.

Summary: This PR adds LOG_FORMAT=console environment variable to local CLI commands to display human-readable logs during development instead of JSON.

Issue Found:

In pkg/predict/predictor.go, there's a mutation bug. The code directly appends to runOptions.Env without making a copy first. If the caller reuses that slice elsewhere, they'll unexpectedly get the LOG_FORMAT=console variable.

[ask-bonk]

Done! Posted a review comment about the slice mutation issue in pkg/predict/predictor.go:64.

github run

[ask-bonk]

LGTM

The slice mutation bug has been fixed. I notice there's a duplicated comment on lines 63-64 of pkg/predict/predictor.go ("Use human-readable log format for local development" appears twice) - that's a minor cleanup item but doesn't affect functionality.

github run

[ask-bonk]

LGTM

github run