Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,23 +19,24 @@ jobs:
strategy:
matrix:
# test against latest update of each major Java version, as well as specific updates of LTS versions:
java: [8, 11.0.x, 13 ]
java: [8, 11, 17 ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure this is a good idea. let's keep both


steps:
- name: Checkout the code
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Cache the maven artifacts
uses: actions/cache@v1
uses: actions/cache@v4
with:
path: ~/.m2/repository
key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ runner.os }}-maven-

- name: Configure java
uses: actions/setup-java@v1
uses: actions/setup-java@v4
with:
distribution: temurin
java-version: ${{ matrix.java }}

- name: Build and run tests
Expand All @@ -53,9 +54,9 @@ jobs:
run: mkdir staging && cp target/*.jar staging

- name: Upload build artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Package
name: Package-java-${{ matrix.java }}
path: staging

- name: Notify slack fail
Expand Down
2 changes: 1 addition & 1 deletion examples/AsyncTranscribeMediaUrl.java
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public static void main(String[] args) {
revAiJobOptions.setSpeakerChannelsCount(null);
revAiJobOptions.setDeleteAfterSeconds(2592000); // 30 days in seconds
revAiJobOptions.setLanguage("en");
revAiJobOptions.setTranscriber("machine_v2");
revAiJobOptions.setTranscriber("machine_v3");

RevAiJob submittedJob;

Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<!-- groupId, artifactId, these namespaces should not be changed -->
<groupId>ai.rev</groupId>
<artifactId>revai-java-sdk</artifactId>
<version>2.5.0</version>
<version>2.6.0</version>
<name>Rev AI SDK for Java</name>
<description>Java SDK for Rev AI API</description>
<url>https://docs.rev.ai/</url>
Expand Down
7 changes: 6 additions & 1 deletion src/main/java/ai/rev/speechtotext/ApiClient.java
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,12 @@ public RevAiJob submitJobUrl(String mediaUrl, RevAiJobOptions options) throws IO
if (options == null) {
options = new RevAiJobOptions();
}
options.setMediaUrl(mediaUrl);
if (options.getSourceConfig() != null) {
throw new IllegalArgumentException(
"source_config is not compatible with submitJobUrl. "
+ "Remove source_config from options or use submitJobUrl(RevAiJobOptions) instead.");
}
options.setSourceConfig(mediaUrl);
return apiInterface.submitJobUrl(options).execute().body();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,18 @@ public void SubmitJobUrl_OnlyUrlIsSpecified_ReturnsRevAiJobInProgress() throws I

assertRevAiJob(revAiJob);
}

@Test
public void SubmitJobUrl_WithMachineV3_ReturnsRevAiJobInProgress() throws IOException {
RevAiJobOptions revAiJobOptions = new RevAiJobOptions();
revAiJobOptions.setMetadata(testName.getMethodName());
revAiJobOptions.setTranscriber("machine_v3");

RevAiJob revAiJob = apiClient.submitJobUrl(SOURCE_URL, revAiJobOptions);

assertRevAiJob(revAiJob);
}

@Test
public void SubmitJobLocalFile_SummarizationOptionsSpecified_ReturnsRevAiJobInProgress()
throws IOException, InterruptedException {
Expand Down
29 changes: 21 additions & 8 deletions src/test/java/ai/rev/speechtotext/unit/RevAiJobTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -226,24 +226,37 @@ public void SubmitJobUrl_UrlAndOptionsAreSpecified_WithAuthHeaders_ReturnsARevAi
assertRevAiJob(revAiJob, mockInProgressJob);
}


@Test
public void SubmitJobUrl_NullOptions_ReturnsIllegalArgumentException() {
public void SubmitJobUrl_DeprecatedWithSourceConfigUrl_ThrowsIllegalArgumentException() {
RevAiJobOptions options = new RevAiJobOptions();
options.setSourceConfig("existing-url.com");
assertThatExceptionOfType(IllegalArgumentException.class)
.isThrownBy(() -> sut.submitJobUrl((RevAiJobOptions) null));
.isThrownBy(() -> sut.submitJobUrl("another-url.com", options));
}

@Test
public void SubmitJobUrl_NullSourceConfig_ReturnsIllegalArgumentException() {
public void SubmitJobUrl_DeprecatedWithSourceConfigAuthHeaders_ThrowsIllegalArgumentException() {
RevAiJobOptions options = new RevAiJobOptions();
options.setSourceConfig(null, SOURCE_AUTH);
assertThatExceptionOfType(IllegalArgumentException.class)
.isThrownBy(() -> sut.submitJobUrl(new RevAiJobOptions()));
.isThrownBy(() -> sut.submitJobUrl(SOURCE_URL, options));
}

@Test
public void SubmitJobUrl_NullSourceConfigUrl_ReturnsIllegalArgumentException() {
public void SubmitJobUrl_DeprecatedUrlAndOptions_SendsSourceConfig() throws IOException {
mockInterceptor.setSampleResponse(gson.toJson(mockInProgressJob));
RevAiJobOptions options = new RevAiJobOptions();
options.setSourceConfig(null, null);
assertThatExceptionOfType(IllegalArgumentException.class)
.isThrownBy(() -> sut.submitJobUrl(options));
options.setMetadata(METADATA);

RevAiJob revAiJob = sut.submitJobUrl(SOURCE_URL, options);

RevAiJobOptions expectedOptions = new RevAiJobOptions();
expectedOptions.setSourceConfig(SOURCE_URL);
expectedOptions.setMetadata(METADATA);
AssertHelper.assertRequestBody(mockInterceptor, expectedOptions, RevAiJobOptions.class);
AssertHelper.assertRequestMethodAndUrl(mockInterceptor, "POST", JOBS_URL);
assertRevAiJob(revAiJob, mockInProgressJob);
}

@Test
Expand Down
Loading