feat(babel): improve filtering capability & performance#1954
feat(babel): improve filtering capability & performance#1954davidtaylorhq wants to merge 1 commit intorollup:masterfrom
Conversation
fdd0778 to
204c3db
Compare
|
Thanks for the PR. We've got a pause on publishing new versions at the moment with the recent NPM change (I'm the blocker here). Once we get the new tokens setup and whatnot, we'll get this reviewed. |
|
@shellscape would you like some help in setting up the OIDC? We've had some really great experiences using release-plan to automate the process and I'd be happy to have a call and walk you through it if that is something you think would be helpful? (I'm one of the maintainers) |
|
@davidtaylorhq u have noted this is not a breaking change in the PR's description - but given the changed peer dependency range it has to be treated as a breaking change. Please rebase this and include the BREAKING CHANGE in the first commit |
- implements 'plugin hook filters' for improved performance under rolldown - passes a new `code` argument to custom filter functions, so that consumers can add more advanced filtering logic - allows custom filter functions to be async BREAKING CHANGES: - drops support for rollup 1.x
ee00073 to
709b2a6
Compare
|
Done, thanks for the review @Andarist |
Andarist
left a comment
There was a problem hiding this comment.
This looks OK but I'm not super involved in the development of this monorepo so I'll leave it to @shellscape to land this
Rollup Plugin Name:
babelThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
Description
drops support for rollup 1.x, which allows simplifying the implementation
implements 'plugin hook filters' for improved performance under rolldown
passes a new
codeargument to custom filter functions, so that consumers can add more advanced filtering logicallows custom filter functions to be async