Fix component registering in subdirectories#3064
Open
pum1k wants to merge 2 commits intoros2:rollingfrom
Open
Conversation
Signed-off-by: pum1k <55055380+pum1k@users.noreply.github.com>
fujitatomoya
approved these changes
Feb 16, 2026
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with green CI.
i think that the approach of using directory properties on PROJECT_SOURCE_DIR is the right fix to avoid the CMake variable scoping problem cleanly without polluting the cache.
one minor suggestion: would it be worth adding a brief comment in the hook file explaining why properties are used like original problem?
Signed-off-by: pum1k <55055380+pum1k@users.noreply.github.com>
Author
|
@fujitatomoya Is this what you meant? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows using
rclcpp_components_register_nodeandrclcpp_components_register_nodesfunctions in subdirectories added byadd_subdirectory(and other non global scopes). This was done by storing the internal data in a property of the project directory instead of variable.Fixes: #1698
Is this user-facing behavior change?
Yes, users will be able to use the above mentioned functions inside nested scopes.
Did you use Generative AI?
No