Create PluginManagerExtention#43
Open
niokasgami wants to merge 2 commits intorpgtkoolmv:masterfrom
niokasgami:patch-1
Open
Create PluginManagerExtention#43niokasgami wants to merge 2 commits intorpgtkoolmv:masterfrom niokasgami:patch-1
niokasgami wants to merge 2 commits intorpgtkoolmv:masterfrom
niokasgami:patch-1
Conversation
Add two new I think Must function to the PluginManager for help more code cleaning From my actual pluginManager but I think those two methods are the most important to be implemented. who are "ToBoolean" who cope the fact it's return a true boolean without having to do the string splitting on the variable declaration which is messy. "ToArray" Allow the use Array in plugin parameters box
orzFly
reviewed
Feb 21, 2017
| * @param {string} parameters | ||
| * @returns {Array<any>} | ||
| */ | ||
| Pluginmanager.toArray = function (plugin, parameters) { |
Author
There was a problem hiding this comment.
ah my bad lol hahah I guess I just made a little typoe without noticing will fix that
Updated the pluginManager extentions because it as a typo I didn't notice lol
|
Just a small note: I think the correct spelling is "Extension" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two new I think Must function to the PluginManager for help more code cleaning
From my actual pluginManager but I think those two methods are the most important to be implemented.
who are
"ToBoolean" who cope the fact it's return a true boolean without having to do the string splitting on the variable declaration which is messy.
"ToArray" Allow the use Array in plugin parameters box