build: Add missing root CMakeLists.txt for P-Net and OSAL configuration#593
Open
Spacecast3r wants to merge 1 commit intortlabs-com:publicfrom
Open
build: Add missing root CMakeLists.txt for P-Net and OSAL configuration#593Spacecast3r wants to merge 1 commit intortlabs-com:publicfrom
Spacecast3r wants to merge 1 commit intortlabs-com:publicfrom
Conversation
b91347e to
ee743f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
While trying to build the P-Net stack following the instructions in the
README.md, I noticed that the rootCMakeLists.txtwas missing from the repository, causing thecmake -B build -S p-netcommand to fail.This Pull Request introduces the missing top-level
CMakeLists.txtto restore the build process and make it compliant with the documentation.Changes included in this PR:
profinetproject and the defaultPNET_OPTION_*andPNET_MAX_*settings.pnet_options.handpnet_version.h.cmake-toolsandOSALviaFetchContent(matching the "Automatic download and build of OSAL" behavior described in the docs).installtarget to properly export the static library, headers, and the scripts inside thetools/folder.Let me know if any adjustments are needed. Thank you!