Fix: Trim whitespace from email before processing#6731
Open
stella-entry wants to merge 1 commit intorubyforgood:mainfrom
Open
Fix: Trim whitespace from email before processing#6731stella-entry wants to merge 1 commit intorubyforgood:mainfrom
stella-entry wants to merge 1 commit intorubyforgood:mainfrom
Conversation
Resolves rubyforgood#6689 - Added .strip to email parameter in update_user_email method - Added test to verify whitespace is stripped from email input - This prevents errors when users accidentally include leading/trailing spaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6689
Summary
&.stripto email parameter inupdate_user_emailmethod to remove leading/trailing whitespaceProblem
When users accidentally include leading or trailing spaces in their email address while updating their profile, the system would attempt to process the email with whitespace intact, resulting in errors.
Solution
Strip whitespace from the email parameter before processing, similar to standard email input sanitization practices.
Testing
strips whitespace from emailinspec/requests/users_spec.rbHow to Test
test@example.comtest@example.com(without spaces)