Open
Conversation
added 2 commits
May 12, 2021 17:10
Stronghold of Security plugins: Door plugin that handles travelling through the stronghold doors Reward plugin that handles receiving rewards Quiz plugin that handles the quiz questions and answers Objects plugin that handles interaction with objects in the dungeon (such as portals, ladders, escape ropes) NPC keys for all NPCs in the Stronghold. NPC Spawns for all of the NPCs in the Stronghold. Travel Locations for the various levels of the dungeon. Pit of Pestilence map data from Revision runejs#455 to the cache, and xteas folder. Music tracks for the Stronghold levels Modify: Change facepalm emote name to Slap Head Dialogue plugin to give dialogues the ability to wrap into new ones if the text is more than 4 lines. waitForPathing() method with optional boolean to ignore interaction distance requirement. Fix: Player's music player button state not loading correctly upon login
added 3 commits
May 13, 2021 10:30
Tynarus
requested changes
May 14, 2021
Member
Tynarus
left a comment
There was a problem hiding this comment.
Preliminary review, please use underscore_case for config keys, anything with a prefix rs: or x:
Tynarus
requested changes
May 14, 2021
added 2 commits
May 14, 2021 12:19
added 2 commits
May 20, 2021 18:43
Contributor
Author
|
I still need to work on the books a bit more, definitely. Right now it's only really applied for one case. But I want to make it more generic so that any BookData object can take the methods and use them to display their info easily. |
added 5 commits
May 22, 2021 17:45
A bug where books with long sections wouldn't display all pages. A typo in a mining message Add: A method to find BookData from book ID. Book data for the Construction guide book Book data for the pie recipe book Modify: The book system to load all books from the books directory The book system to be more generic, and much simpler in certain areas. Removed lots of unnecessary duplicate calls. Rename: stronghold-of-security-book.plugin to books.plugin loadStrongholdOfSecurityBook() to loadBookData()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft adds support for the Stronghold of Security.
Features of this change include:
Aspects not yet implemented are:
In addition to these changes, this commit also: