docs(i2c): clarify write_read operation in examples#732
Closed
ramadhan-dev-bright wants to merge 1 commit intorust-embedded:masterfrom
Closed
docs(i2c): clarify write_read operation in examples#732ramadhan-dev-bright wants to merge 1 commit intorust-embedded:masterfrom
ramadhan-dev-bright wants to merge 1 commit intorust-embedded:masterfrom
Conversation
Member
|
Imo this doesn't add anything in terms of readability, this is just explaining what that line (imo) clearly demonstrates. Happy to be overruled by @rust-embedded/hal, though. |
Author
|
Hi @MabezDev, thanks for the feedback! As a beginner, I felt that
explicitly mentioning the register-then-read flow helps avoid confusion for
those new to I2C traits. But I completely understand if the team prefers to
keep the examples minimal and concise
Pada Kam, 26 Mar 2026 9.00 PM, Scott Mabin ***@***.***>
menulis:
… *MabezDev* left a comment (rust-embedded/embedded-hal#732)
<#732?email_source=notifications&email_token=BN7HWMVXIPQGG7H36K6SS5D4SUZYPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJTGUYDSNBVHE32M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2LK4DSL5RW63LNMVXHIX3POBSW4X3DNRUWG2Y#issuecomment-4135094597>
Imo this doesn't add anything in terms of readability, this is just
explaining what that line (imo) clearly demonstrates. Happy to be overruled
by @rust-embedded/hal <https://github.com/orgs/rust-embedded/teams/hal>,
though.
—
Reply to this email directly, view it on GitHub
<#732?email_source=notifications&email_token=BN7HWMVXIPQGG7H36K6SS5D4SUZYPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJTGUYDSNBVHE32M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2LK4DSL5RW63LNMVXHIX3POBSW4X3DNRUWG2Y#issuecomment-4135094597>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BN7HWMXN7WUCKVQ4UYSFQPT4SUZYPAVCNFSM6AAAAACXAOGYX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCMZVGA4TINJZG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added comments to clarify the write_read operation in I2C examples for better readability