Skip to content

Add -Z unstable-options to rustc invocation to make --target work #21757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FabianWolff wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Add -Z unstable-options to rustc invocation to make --target work #21757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/project-model/src/toolchain_info/rustc_cfg.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ fn rustc_print_cfg(
};

let mut cmd = sysroot.tool(Tool::Rustc, current_dir, extra_env);
cmd.args(RUSTC_ARGS);
cmd.args(["-Z", "unstable-options"]).args(RUSTC_ARGS);
Copy link
Copy Markdown
Member

@Veykril Veykril Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will break the command for all stable toolchains

Copy link
Copy Markdown
Member

@Veykril Veykril Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could heuristically check if the target ends with .json, emit this option + adding RUSTC_BOOTSTRAP=1 to the environment

cmd.arg("-O");
if let Some(target) = target {
cmd.args(["--target", target]);
Expand Down
Loading