fix: Fix extract variable on arg with comma#21936
Open
A4-Tacks wants to merge 1 commit intorust-lang:masterfrom
Open
fix: Fix extract variable on arg with comma#21936A4-Tacks wants to merge 1 commit intorust-lang:masterfrom
A4-Tacks wants to merge 1 commit intorust-lang:masterfrom
Conversation
Example
---
```rust
fn main() {
let x = 2;
foo(
x + x,
$0x - x,$0
)
}
```
**Before this PR**
```rust
fn main() {
let x = 2;
let $0var_name = x + x;
foo(
var_name,
x - x,
)
}
```
**After this PR**
```rust
fn main() {
let x = 2;
let $0var_name = x - x;
foo(
x + x,
var_name,
)
}
```
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
requested changes
Apr 3, 2026
| SyntaxKind::BLOCK_EXPR => { | ||
| ast::BlockExpr::cast(node).filter(|it| it.is_standalone()).map(ast::Expr::from) | ||
| } | ||
| SyntaxKind::ARG_LIST => ast::ArgList::cast(node)? |
Contributor
There was a problem hiding this comment.
This will also pass when multiple args are selected. Also ARG_LIST isn't the only place for things like that (e.g. ARRAY_EXPR is too). IMO we should disable the assist when the comma is selected, but I also agree to enable it if it's confined to where only a single item is selected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example
Before this PR
After this PR