Add new failed_merged_doctest_compilation rustdoc lint#148866
Open
GuillaumeGomez wants to merge 2 commits intorust-lang:mainfrom
Open
Add new failed_merged_doctest_compilation rustdoc lint#148866GuillaumeGomez wants to merge 2 commits intorust-lang:mainfrom
failed_merged_doctest_compilation rustdoc lint#148866GuillaumeGomez wants to merge 2 commits intorust-lang:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally took the time to write this lint. We need to have a compiler context in order to be able to emit the lint, but I'm not sure if
DiagCtxtHandledoesn't provide it somehow... Anyway, I'm expecting performance regression because we keep the compiler and its internals around for much longer, stacking doctests memory on top of the allocated memory to the current crate (which is why I'd really love to see if it's possible to emit lints fromDiagCtxtHandlesomehow, gonna investigate).Also: both lint name and lint message are very much up to debate.
r? @fmease