-
Notifications
You must be signed in to change notification settings - Fork 1k
Update post install message to show only the source methods that are relevant to your system. #4806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ryankopf
wants to merge
1
commit into
rust-lang:main
Choose a base branch
from
ryankopf:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+74
−30
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
View changes since the review
I think this is a good idea, but I wonder if we should also keep some kind of indication that there is support for these other shells.
Maybe there should be a page in the documentation that covers this (if there isn't one already), and we could link to it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about this after your comment. I looked at the code and there are not many places we put "just in case, look at the docs here: [url]".
I think we already rely very heavily on the "get_supported_shells" function and it seems to have served well over the years. If they have a shell that isn't discovered by "get_supported_shells" for some reason, it's .rc files or whatever it uses will not get updated by rustup in the first place, and we don't show a documentation message related to that issue. Like there's no "just in case we didn't find your shell, look here: [url]" message in what we're already doing.
So I think it's a better strategy to just make sure the "get_supported_shells" does a really good job of detecting whatever shells you have, which I think we have done since there I searched issues for "is:issue state:open get_supported_shells" and "shells missing" and there don't seem to be any complaints about it.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djc @ryankopf Actually a smarter way to do this would be to dump all
envfiles in one place and tell the user "just source anything you want in this folder if you install any new shells later".This is part of the plan (#3639), but for now I'd suggest postponing this because we are making the installation path change (#247) and the former change will be easier afterwards.
Your proposal is going exactly in the direction we originally wanted though, thanks again!