add support for require conversation resolution#2374
Open
Conversation
Dry-run check results |
marcoieni
commented
Apr 2, 2026
| pub name: Option<String>, | ||
| pub dismiss_stale_review: bool, | ||
| #[serde(default)] | ||
| pub require_conversation_resolution: bool, |
Member
Author
There was a problem hiding this comment.
In another PR, Kobzol said that adding new fields is not a breaking change for triagebot 👍
4919ee8 to
32302c0
Compare
32302c0 to
dac0a38
Compare
Member
Author
Member
Author
|
If you are changing the data structures, please make sure that the changes are not going to break serde deserialization (adding a field is fine; removing or renaming a field isn't). If you must do a breaking change to the format, make sure to coordinate it with all the users of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





This setting was set manually from the UI. With this PR we add in
teamthe ability to set this field via toml.As you can see from the screenshots, all the repositories edited here have "require conversation resolution before merging" checked.
So we are just encoding this information in the toml files.
As you can see from the empty dry run, no changes will be done to GitHub. However if you check the last edit of the dry run (before I pushed the changes to the toml files), you can see that the dry run was correctly detecting these repos.