Open
Conversation
madsmtm
force-pushed
the
madsmtm/readme-example
branch
from
6d75db3 to
fa540ce
Compare
Don't use a utility module in the first example that users see, use the actual Winit API.
madsmtm
force-pushed
the
madsmtm/readme-example
branch
from
fa540ce to
731fb8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm generally against utility helpers in examples, example code is allowed to contain duplication.
At the very least, we shouldn't use a utility module in the first example that users see, we should use the actual Winit API to show how to manage the surface between suspend/resume calls. This PR fixes that (we can consider changing the other examples later).