Skip to content

Fix subtract with overflow#79

Merged
hschimke merged 4 commits intorxing-core:mainfrom
forzafedor:fix-subtract-with-overflow
Mar 6, 2026
Merged

Fix subtract with overflow#79
hschimke merged 4 commits intorxing-core:mainfrom
forzafedor:fix-subtract-with-overflow

Conversation

@forzafedor
Copy link
Copy Markdown
Contributor

#78

@hschimke
Copy link
Copy Markdown
Collaborator

hschimke commented Mar 5, 2026

Thank you for this. I'm approving the tests to run now. I'll review tonight or tomorrow.

@forzafedor
Copy link
Copy Markdown
Contributor Author

The tests failed, I mixed up the arguments for the second subtraction. It's strange that I also ran the tests, but without --release flag, and everything passed.

I fixed the error.

@hschimke hschimke merged commit a50fd6a into rxing-core:main Mar 6, 2026
1 check passed
@hschimke
Copy link
Copy Markdown
Collaborator

hschimke commented Mar 6, 2026

Thanks for finding this! Merged for the next release.

@forzafedor forzafedor deleted the fix-subtract-with-overflow branch March 23, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants