Add support dreame.vacuum.ma1808 and dreame.vacuum.mb1808#1774
Open
st7105 wants to merge 21 commits intorytilahti:masterfrom
Open
Add support dreame.vacuum.ma1808 and dreame.vacuum.mb1808#1774st7105 wants to merge 21 commits intorytilahti:masterfrom
st7105 wants to merge 21 commits intorytilahti:masterfrom
Conversation
This reverts commit 2546b04.
Codecov Report
@@ Coverage Diff @@
## master #1774 +/- ##
==========================================
- Coverage 80.88% 80.86% -0.02%
==========================================
Files 193 193
Lines 18594 18604 +10
Branches 4019 4021 +2
==========================================
+ Hits 15039 15045 +6
- Misses 3277 3281 +4
Partials 278 278
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rytilahti
requested changes
Mar 13, 2024
Owner
rytilahti
left a comment
rytilahti
left a comment
There was a problem hiding this comment.
Could you please rebase on top of the current master branch and remove the changes irrelevant to dreame.vacuum*?
| # Indicator light (siid=7) | ||
| "led_brightness": {"siid": 7, "piid": 1}, | ||
| }, | ||
| "leshow.heater.nfj3lx": { |
Owner
There was a problem hiding this comment.
These are irrelevant changes, right?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://home.miot-spec.com/spec/dreame.vacuum.ma1808
https://home.miot-spec.com/spec/dreame.vacuum.mb1808