Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1940 +/- ##
==========================================
+ Coverage 82.26% 82.30% +0.04%
==========================================
Files 197 197
Lines 19139 19188 +49
Branches 1050 1050
==========================================
+ Hits 15744 15793 +49
Misses 3218 3218
Partials 177 177 ☔ View full report in Codecov by Sentry. |
dsh0416
changed the title
dsh0416
changed the title
|
By randomly comment out some of the properties make the fetching process works. |
Problem confirmed. It looks like the default |
| return RoidmiVacuumStatus( | ||
| { | ||
| prop["did"]: prop["value"] if prop["code"] == 0 else None | ||
| # max_properties limmit to 10 to avoid "Checksum error" messages from the device. |
There was a problem hiding this comment.
Also, this comment should be removed, since the max_properties is not properly limited at all, and there is also a typo in this comment. Maybe it is copy-pasted from somewhere else.
There was a problem hiding this comment.
Yeah, that's probably just due to some copy&pasting. Please remove changes to roidmivacuum_miot from this PR (as they are unrelated, but feel free to create a separate PR to remove those if you wish!) and then this is good to go 👍
| return RoidmiConsumableStatus( | ||
| { | ||
| prop["did"]: prop["value"] if prop["code"] == 0 else None | ||
| # max_properties limmit to 10 to avoid "Checksum error" messages from the device. |
| return RoidmiCleaningSummary( | ||
| { | ||
| prop["did"]: prop["value"] if prop["code"] == 0 else None | ||
| # max_properties limmit to 10 to avoid "Checksum error" messages from the device. |
|
I don't think I would be able to fix the readthedocs CI properly, so that this commit is now ready for review. |
| return RoidmiVacuumStatus( | ||
| { | ||
| prop["did"]: prop["value"] if prop["code"] == 0 else None | ||
| # max_properties limmit to 10 to avoid "Checksum error" messages from the device. |
There was a problem hiding this comment.
Yeah, that's probably just due to some copy&pasting. Please remove changes to roidmivacuum_miot from this PR (as they are unrelated, but feel free to create a separate PR to remove those if you wish!) and then this is good to go 👍
dsh0416
left a comment
dsh0416
left a comment
There was a problem hiding this comment.
suggest for revert
|
reverted. Thank you for reviewing, and I may move the comments changes to a further PR. @rytilahti |
|
@rytilahti Hello, is there anything that needs to be done for this pull request to be merged? I have this device, and I am interested in having support for it in the library |
3 participants
Meanwhile, for
xiaomi.airp.va2b, it would cause{'code': -9999, 'message': 'user ack timeout'}when queryingstatus, and I am still figuring why.