Permit setting aqi_realtime_update_duration and do not override the value of aqi_realtime_update_duration if it is set for the Mi Air Purifier 3/3H (zhimi.airpurifier.mb3).#2040
Conversation
| "filter_rfid_product_id": "0:0:41:30", | ||
| "filter_rfid_tag": "10:20:30:40:50:60:7", | ||
| "button_pressed": "power", | ||
| "aqi_realtime_update_duration": 0, |
There was a problem hiding this comment.
The default value for my 3H for this setting is 0. I can move this change to device specific init state if that is desired.
…alue of aqi_realtime_update_duration if it is set for the Mi Air Purifier 3/3H (zhimi.airpurifier.mb3). Tested against a 3H. Signed-off-by: david <db@d1b.org>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2040 +/- ##
==========================================
+ Coverage 82.26% 82.30% +0.03%
==========================================
Files 197 197
Lines 19145 19181 +36
Branches 1052 1054 +2
==========================================
+ Hits 15750 15786 +36
Misses 3218 3218
Partials 177 177 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| assert status.aqi_realtime_update_duration == specific_value | ||
|
|
||
| def test_set_aqi_realtime_update_duration_negative_value(self): |
There was a problem hiding this comment.
I am not sure what other models have or do not have the ability to set and or provide information on aqi_realtime_update_duration_negative_value are there other changes that I should do in relation to this change and the related tests ?
|
I would like to make it possible to set a custom AQI update interval (re #1387). While this seems to work - it seems like the device doesn't want to "stick" to a specific update duration after you set it. The value it provides back is often 0 after setting the value to a non-zero value ... |
1 participant
Tested against a 3H.