Conversation
71a69ac to
9e52ec1
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71a69ac009
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,3 @@ | |||
| [[IgnoredVulns]] | |||
| id = "GHSA-w5hq-g745-h8pq" | |||
There was a problem hiding this comment.
Clear the pnpm audit advisory instead of only OSV
This ignore only affects OSV-Scanner, but the blocking CI security job still runs pnpm audit --audit-level high without --prod or --ignore in .github/workflows/ci.yml, and pnpm audit --help shows --prod is the option that restricts auditing to production dependencies. Because package.json still includes Lighthouse as a dev dependency and pnpm-lock.yaml still resolves its @lhci/cli path to uuid: 8.3.2, the high-severity GHSA-w5hq-g745-h8pq alert will continue to fail that gate even though OSV is suppressed here.
Useful? React with 👍 / 👎.
9e52ec1 to
49bbb95
Compare
What
openssland direct/runtimerandversions.Why
master.How
opensslmoves from0.10.75to0.10.78through the lockfile, pulling the matchingopenssl-sysupdate.randresolutions move to fixed0.8.6and0.9.3releases.rand 0.7.3is documented as a Tauri build-time transitive dependency throughtauri-utils/selectors/phf, anduuid 8.3.2is documented as a dev-only Lighthouse CI CLI dependency.Testing
cargo test --manifest-path src-tauri/Cargo.tomlpassed in an isolated checkout after creating a temporary untrackeddist/directory required by Tauri's context macro.osv-scannerwas not installed locally, so the PR workflow remains the scan authority.Performance Impact
Risk / Notes
uuidalert and the Tauri build-timerand 0.7.3path./Users/d/Projects/AssistSupportwas not modified; it has unrelated dirty files and is behindorigin/master.