fix: resolve multiple regressions from prettier/rubocop refactor#419
Merged
natsuki615 merged 2 commits intosc0v:masterfrom Apr 2, 2026
Merged
Conversation
tomas-goncalves
force-pushed
the
fix/params-expect-permitted-attributes
branch
3 times, most recently
from
a139f52 to
c3eb868
Compare
- Unwrap permitted_attributes from array in params.expect calls (faq, participants, waivers controllers) - Assign to @Participant instead of @show in participants#show - Restore javascript_include_tag ERB tag and fix videoId HTML escaping in safety briefing video partial - Call hardhat? instead of removed is_hardhat? method in tools/show
tomas-goncalves
force-pushed
the
fix/params-expect-permitted-attributes
branch
from
c3eb868 to
8dc6f5b
Compare
natsuki615
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes several bugs introduced by the prettier v3 / rubocop refactor in #393:
params.expectcalls infaq,participants, andwaiverscontrollers hadpermitted_attributeswrapped in an extra array, causing "param is missing or the value is empty or invalid" errorsparticipants#showassigned to@showinstead of@participant, causingNoMethodErroron the profile page_video.html.erbhadjavascript_include_tagas bare text (missing<%= %>), so the YouTube API was never loaded;videoIdalso used.to_jsonwithoutraw(), producing HTML-escaped"in JStools/show.html.erbcalled the removedis_hardhat?instead ofhardhat?