Verify Starlette 1.0.0 compatibility#846
Open
mitchh456 wants to merge 2 commits intofix/fastmcp-3-compatibilityfrom
Open
Verify Starlette 1.0.0 compatibility#846mitchh456 wants to merge 2 commits intofix/fastmcp-3-compatibilityfrom
mitchh456 wants to merge 2 commits intofix/fastmcp-3-compatibilityfrom
Conversation
mitchh456
force-pushed
the
fix/836-starlette-1.0-compatibility
branch
from
6b8eb10 to
1e57d8b
Compare
mitchh456
force-pushed
the
fix/fastmcp-3-compatibility
branch
from
b490695 to
ec800d2
Compare
Add dedicated tox environments to test against both Starlette 0.36.x and 1.0.x, verifying compatibility of Scout's ASGI middleware with the Starlette 1.0 stable release. Also update setup.py classifiers to reflect tested Django 5.x and Python 3.13/3.14 support. Closes #836 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove starlette 0.36 envs (not relevant to 1.0 compat verification) - Run only starlette tests in starlette envs (avoids collection errors from Django tests when Django is not installed) - Add asgiref dep (needed by test, normally a Django transitive dep) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mitchh456
force-pushed
the
fix/836-starlette-1.0-compatibility
branch
from
1e57d8b to
10af94d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScoutMiddlewareuses pure ASGI3 interfaces (__call__(self, scope, receive, send)) which are stable across Starlette versionssetup.pyclassifiers to reflect tested Django 5.0/5.1/5.2 and Python 3.13/3.14 supportCompatibility audit
Scout's
ScoutMiddlewareinsrc/scout_apm/async_/starlette.py:starlette.background.BackgroundTaskimport is stable core APIscope["endpoint"],scope["type"],scope["user"])__call__viawrapt.decorator-- public interfaceTest plan
tests/integration/test_starlette.pycover middleware injection, background tasks, error handling, and authenticationCloses #836
Generated with Claude Code