Slimmable interface and SlimmableContainer#242
Merged
sdatkinson merged 5 commits intosdatkinson:mainfrom Mar 11, 2026
Merged
Conversation
3650ca5 to
91efeb0
Compare
Contributor
Author
|
Integration tests failed for some reason but that seems to be unrelated to anything I implemented here. Investigating. |
sdatkinson
requested changes
Mar 10, 2026
Owner
sdatkinson
left a comment
There was a problem hiding this comment.
A few things plz, see comments
sdatkinson
requested changes
Mar 11, 2026
Owner
sdatkinson
left a comment
There was a problem hiding this comment.
Just a few other asks since we were working in parallel :)
| // Test that SetSlimmableSize is called before processing (simulates --slim flow) | ||
| void test_slim_applied_before_processing() | ||
| { | ||
| std::cout << " test_slim_applied_before_processing" << std::endl; |
Owner
There was a problem hiding this comment.
Have the tests be quiet on the happy path
added 2 commits
March 11, 2026 10:37
… Made max_value exclusive in SetSlimmableSize.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added virtual void SetSlimmableSize(const double val) to DSP. Default is a no-op. val ranges from 0.0 (minimum size) to 1.0 (maximum size).
Subclasses override this to reduce computational cost in a model-specific way.
A new ContainerModel class that uses the slimmable interface to switch between multiple complete DSP models at different quality tiers.
immediately ready for process().
The NAM file format nests full model specs inside config.submodels[].model, with an empty top-level weights array.
A 3-tier container using lstm.nam (small, max_value=0.33), wavenet.nam (medium, max_value=0.66), and nano_relu.nam (large, max_value=1.0).
10 tests covering:
Developed with support and sponsorship from TONE3000