feat(giga): implement iterator for the cachekv#2994
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
|
|
||
| func (mi *memIterator) Key() []byte { | ||
| if !mi.Valid() { | ||
| panic("iterator is invalid") |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
|
|
||
| func (mi *memIterator) Value() []byte { | ||
| if !mi.Valid() { | ||
| panic("iterator is invalid") |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2994 +/- ##
==========================================
- Coverage 58.32% 58.31% -0.01%
==========================================
Files 2079 2079
Lines 171753 171792 +39
==========================================
+ Hits 100172 100182 +10
- Misses 62652 62681 +29
Partials 8929 8929
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
codchen
approved these changes
Mar 3, 2026
stevenlanders
approved these changes
Mar 9, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 30, 2026
## Describe your changes and provide context #2994 introduced an iterator for the cachekv store for the specific purpose of migrating balances during association. There are concerns with that change -- in particular future stores won't support iterators at all. Instead, we can simply fallback to v2 when associatons need to occur, similar to how we handle interop. This PR makes that change, and adds a test for it. ## Testing performed to validate your change
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 30, 2026
## Describe your changes and provide context #2994 introduced an iterator for the cachekv store for the specific purpose of migrating balances during association. There are concerns with that change -- in particular future stores won't support iterators at all. Instead, we can simply fallback to v2 when associatons need to occur, similar to how we handle interop. This PR makes that change, and adds a test for it. ## Testing performed to validate your change (cherry picked from commit 95ed1f5)
jewei1997
pushed a commit
that referenced
this pull request
Mar 30, 2026
## Describe your changes and provide context #2994 introduced an iterator for the cachekv store for the specific purpose of migrating balances during association. There are concerns with that change -- in particular future stores won't support iterators at all. Instead, we can simply fallback to v2 when associatons need to occur, similar to how we handle interop. This PR makes that change, and adds a test for it. ## Testing performed to validate your change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Since we need Giga to interoperate with v2, we need to return all balances for accounts that are being migrated. This PR implements the Iterator to do that.
If we don't want to implement Iterator on the cachekv, an alternative is to just squish the logic into
GetAllBalancesorSpendableCoinsdirectly. That would look something like this:Testing performed to validate your change