-
Notifications
You must be signed in to change notification settings - Fork 146
Add make_latest property to the GH release POST request during publish
#1157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
774af87
Add make_latest publish flag and isLatestRelease helper
pfarnach 4f8f87d
Merge branch 'master' into make-latest-support
pfarnach 8675813
Merge branch 'master' into make-latest-support
pfarnach 0603388
Merge branch 'master' into make-latest-support
pfarnach 693913e
fix integration tests
pfarnach 0f49844
Add two new integration tests for publishing releases without assets
pfarnach a284821
Add another integration test for maintenance releases
pfarnach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| export default function isLatestRelease({ type, main }) { | ||
| return type === "release" && main ? "true" : "false"; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import test from "ava"; | ||
| import isLatestRelease from "../lib/is-latest-release.js"; | ||
|
|
||
| test("Test for empty object", (t) => { | ||
| const branch = {}; | ||
| t.is(isLatestRelease(branch), "false"); | ||
| }); | ||
|
|
||
| test("Test if type release and main is used correctly", (t) => { | ||
| const branch = { | ||
| type: "release", | ||
| main: true, | ||
| }; | ||
| t.is(isLatestRelease(branch), "true"); | ||
| }); | ||
|
|
||
| test("Test if type prerelease is used correctly", (t) => { | ||
| const branch = { | ||
| type: "prerelease", | ||
| main: true, | ||
| }; | ||
| t.is(isLatestRelease(branch), "false"); | ||
| }); | ||
|
|
||
| test("Test if type main property as boolean is used correctly", (t) => { | ||
| const branch = { | ||
| type: "release", | ||
| main: false, | ||
| }; | ||
| t.is(isLatestRelease(branch), "false"); | ||
| }); | ||
|
|
||
| test("Test maintenance branch returns false", (t) => { | ||
| const branch = { | ||
| type: "maintenance", | ||
| main: false, | ||
| }; | ||
| t.is(isLatestRelease(branch), "false"); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it wouldnt be safe to specifically target the
mainbranch sincemasteris still common and there are other patterns that teams use for naming their stable release branch. this would need to consider how the release branches are defined for the specific projectUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @travi thanks for looking at my PR!
I'm having trouble finding explicit docs about the
branchobject (the closest thing I could find is here) so I'm going off my very cursory understanding of the source code. It seems likemainin this context is a boolean (rather than a string representing the branch name) that's set here, based on the index of the branch that's passed into the config. In any case, that also doesn't seem very reliable unless there's something ensuring the main/master/whatever branch is the first element there.Would it be enough to just check the
typevalue and remove themaincheck? From what I can tell, the other possible values aremaintenanceandprereleasebut could use a gut-check on that.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you did find the closest thing to documentation on that detail. with the lack of a better doc, i went spelunking through what the core package passes to this lifecycle method to refresh my understanding. looks like i landed in the same places you explored. some of this is from before i joined the project and doesnt always stick in my brain properly. i think you landed on the correct approach.
mainaccounts for "next"-type releases. not a prerelease, not a maintenance release. normal release, but not to the default channel. so given that,mainis needed for determining "latest" and you've handled it appropriately here.sorry for my confusion before and thanks for your patience
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this check seems not enough, we use this
branchesconfig:{ "branches": [ { "name": "maint/+([0-9])?(.{+([0-9]),x}).x", "range": "${name.replace(/^maint\\//g, '')}" }, "main" ] }https://github.com/containerbase/base/blob/main/.releaserc.json
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you put
"main"first in the array, does it work?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, then it doesn't accept the maintenace branches and treats them as next.
but that was not the reason. i'v debugged a little and found the this change was not enough when using assets.
after asset upload there's a patch call which also makes the release as latest by default. I've created a fix