Skip to content

SG-22646 Replaced references to Shotgun with ShotGrid#21

Merged
mathurf merged 2 commits intomasterfrom
sg-22646-shotgrid
Jun 2, 2021
Merged

SG-22646 Replaced references to Shotgun with ShotGrid#21
mathurf merged 2 commits intomasterfrom
sg-22646-shotgrid

Conversation

@eshokrgozar
Copy link
Contributor

No description provided.

@eshokrgozar eshokrgozar requested review from jfboismenu and mathurf May 27, 2021 15:33
Copy link
Contributor

@jfboismenu jfboismenu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'm assuming the process to recompile the plugin was well documented then? I don't see any changes to the docs.

@jfboismenu
Copy link
Contributor

@mathurf , your turn!

@eshokrgozar
Copy link
Contributor Author

👍 I'm assuming the process to recompile the plugin was well documented then? I don't see any changes to the docs.

Yeah. So the README has a bunch of information about this. The part that was missing was in this PR. I'm not sure if we need to fix the timecode thing or just disable it as mentioned in the PR. But it doesn't work with it on.

Copy link

@mathurf mathurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found this Shotgun mention
image

@eshokrgozar
Copy link
Contributor Author

found this Shotgun mention
image

fixed

@eshokrgozar eshokrgozar requested a review from mathurf June 1, 2021 19:07
Copy link

@mathurf mathurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mathurf mathurf merged commit 2beaa62 into master Jun 2, 2021
@mathurf mathurf deleted the sg-22646-shotgrid branch June 2, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants