SG-42549 Replace OS-specific binary scripts with install_binary.py#320
Draft
julien-lang wants to merge 3 commits intomasterfrom
Draft
SG-42549 Replace OS-specific binary scripts with install_binary.py#320julien-lang wants to merge 3 commits intomasterfrom
julien-lang wants to merge 3 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #320 +/- ##
=======================================
Coverage 65.82% 65.82%
=======================================
Files 24 24
Lines 1870 1870
=======================================
Hits 1231 1231
Misses 639 639
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
install_binary.py is a single cross-platform Python script that replaces install_binary_linux.sh, install_binary_mac.sh and install_binary_windows.ps1. Platform detection is done via sys.platform at runtime. pipelines.yml already calls python install_binary.py - this commit adds the script and removes the three old OS-specific scripts. SG-42304 Clean up pipeline naming and move git add to pipeline steps
julien-lang
force-pushed
the
ticket/SG-42304-next
branch
from
93161b3 to
88ae513
Compare
julien-lang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install_binary.py is a single cross-platform Python script that replaces install_binary_linux.sh, install_binary_mac.sh and install_binary_windows.ps1. Platform detection is done via sys.platform at runtime.
pipelines.yml already calls python install_binary.py - this commit adds the script and removes the three old OS-specific scripts.
SG-42304 Clean up pipeline naming and move git add to pipeline steps