Add support for compiling on vanilla mipsel GCC toolchain#15
Open
etherealvisage wants to merge 5 commits intosignal11:masterfrom
Open
Add support for compiling on vanilla mipsel GCC toolchain#15etherealvisage wants to merge 5 commits intosignal11:masterfrom
etherealvisage wants to merge 5 commits intosignal11:masterfrom
Conversation
This allows usb_hal to pass the first stage of compilation on an unmodified mipsel GCC toolchain.
This function/macro does not exist on vanilla mipsel GCC.
This reverts commit 6eef515.
This uses the locally-defined macros and makes these files compile on vanilla mipsel GCC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As previously discussed in issue #14, I was working on supporting a vanilla mipsel GCC toolchain in m-stack. The changes I made are quite minor, but as they're in a working state now I feel it's probably appropriate to get some feedback here.
There are two main things to consider here:
xc.h) one can include to get access to useful SFR declarations, such asU1IR. However, there is already a standardized way to allow the user to configure things for the library, which is the fileusb_config.h. As such, I assume now that if using a vanilla compiler, you must include a header file to provide SFR declarations.Please let me know what you think! I'm happy to sign the ICLA and make any modifications you feel are necessary.
Thank you.