Minimum coverage by group check

[mikhliuk-k]

I added support for coverage checking by group since we needed it for our project and noticed there was an open issue about it. This feature is useful as we’re gradually increasing test coverage across our app, so we can enforce coverage checks on specific parts. Here’s an example of how to use it from the README.

SimpleCov.minimum_coverage_by_group 'Models' => 80, 'Controllers' => 60
# same as above (the default is to check line coverage)
SimpleCov.minimum_coverage_by_group 'Models' => { line: 80 }, 'Controllers' => { line: 60 }
# check for a minimum line and branch coverage for 'Models' and 'Controllers' groups
SimpleCov.minimum_coverage_by_group 'Models' => { line: 90, branch: 80 }, 'Controllers' => { line: 60, branch: 50 }

[coorasse]

Lovely! This is also helpful when enabling the new coverage for eval. So we can enable coverage for erb files without dropping the global coverage.

[cb341]

This would be a very welcome change indeed!

[cb341]

Any updates regarding this pull request?

[jebentier]

@PragTob This additional functionality for setting minimum coverage by group would be very valuable. We're currently restructuring our Rails monolith to group functionality via Packwerk packages, allowing us to track overall coverage as well as per-package coverage separately via groups. Being able to systematically ratchet down coverage requirement on a per-package basis would be amazing. Would you mind looking into this PR?

[YegorZdanovich]

@PragTob @amatsuda hey guys, any chance it can be reviewed and merged?

[aguynamedben]

WANT

[viralpraxis]

That'd be an awesome feature.

[cb341]

What's the state of this PR?
Would be super cool

[denblackstache]

Hey @amatsuda, what's blocking this PR from being merged?

[sferik]

Overall, this is a great feature. The only issue I see is if a user specifies a in minimum_coverage_by_group that doesn't match any configured add_group, result.groups.fetch(group_name) will raise a KeyError with no helpful context. It should either raise a clear error message or warn and skip the missing group. There is also no test for this scenario.

That said, I’m happy to merge this patch as-is and fix that issue before shipping this feature. Thanks for the PR!