Skip to content

Revert "Add @Required annotation with optional validator (#1558)"#1566

Merged
WilliamBergamin merged 2 commits intomainfrom
revert-#1558
Mar 10, 2026
Merged

Revert "Add @Required annotation with optional validator (#1558)"#1566
WilliamBergamin merged 2 commits intomainfrom
revert-#1558

Conversation

@WilliamBergamin
Copy link
Contributor

@WilliamBergamin WilliamBergamin commented Mar 4, 2026

This reverts commit 372fff8.

In the future will will readresse this issues attempted to be resolved by this commit

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@WilliamBergamin WilliamBergamin self-assigned this Mar 4, 2026
@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.41%. Comparing base (ab70b31) to head (7205d0e).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...main/java/com/slack/api/util/json/GsonFactory.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1566   +/-   ##
=========================================
  Coverage     73.41%   73.41%           
+ Complexity     4534     4523   -11     
=========================================
  Files           479      477    -2     
  Lines         14330    14283   -47     
  Branches       1495     1487    -8     
=========================================
- Hits          10520    10486   -34     
+ Misses         2919     2910    -9     
+ Partials        891      887    -4     
Flag Coverage Δ
jdk-14 73.41% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WilliamBergamin WilliamBergamin marked this pull request as ready for review March 10, 2026 19:49
@WilliamBergamin WilliamBergamin requested a review from a team as a code owner March 10, 2026 19:49
@WilliamBergamin WilliamBergamin added this to the 1.47.0 milestone Mar 10, 2026
@WilliamBergamin WilliamBergamin merged commit 6ad1ce8 into main Mar 10, 2026
12 of 13 checks passed
@WilliamBergamin WilliamBergamin deleted the revert-#1558 branch March 10, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant