Skip to content

Skip OperationGenerator in types-only codegen mode #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adwsingh merged 4 commits into from
Mar 17, 2026
+10 −2
Merged

Skip OperationGenerator in types-only codegen mode #1083

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eaa7f23
fix: skip OperationGenerator in types-only codegen mode
Mar 17, 2026
f56810f
Update codegen/codegen-plugin/src/main/java/software/amazon/smithy/ja…
AgentKWang Mar 17, 2026
b91f2d5
Merge branch 'main' into fix/types-mode-skip-operation-generator
AgentKWang Mar 17, 2026
1434ca7
Merge branch 'main' into fix/types-mode-skip-operation-generator
sugmanue Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ...codegen-plugin/src/main/java/software/amazon/smithy/java/codegen/DirectedJavaCodegen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,9 @@ public void generateOperation(GenerateOperationDirective<CodeGenerationContext,
if (isSynthetic(directive.shape())) {
return;
}
if (isTypesOnly()) {
return;
}
if (modes.contains(CodegenMode.SERVER)) {
new OperationInterfaceGenerator().accept(directive);
}
Expand All @@ -144,8 +147,7 @@ public void generateOperation(GenerateOperationDirective<CodeGenerationContext,
@Override
public void generateService(GenerateServiceDirective<CodeGenerationContext, JavaCodegenSettings> directive) {
// In TYPES-only mode, generateService is a no-op (the synthetic service has no real service shape)
if (modes.contains(CodegenMode.TYPES) && !modes.contains(CodegenMode.CLIENT)
&& !modes.contains(CodegenMode.SERVER)) {
if (isTypesOnly()) {
return;
}

Expand Down Expand Up @@ -193,4 +195,10 @@ public void customizeAfterIntegrations(CustomizeDirective<CodeGenerationContext,
private static boolean isSynthetic(Shape shape) {
return shape.getId().getNamespace().equals(SyntheticServiceTransform.SYNTHETIC_NAMESPACE);
}

private boolean isTypesOnly() {
return modes.contains(CodegenMode.TYPES)
&& !modes.contains(CodegenMode.CLIENT)
&& !modes.contains(CodegenMode.SERVER);
}
}