Skip to content

Comments

fix: skip ExclusiveModeAPI resolution to prevent Linux segfault#3705

Merged
rxri merged 3 commits intospicetify:mainfrom
romdotdog:main
Feb 20, 2026
Merged

fix: skip ExclusiveModeAPI resolution to prevent Linux segfault#3705
rxri merged 3 commits intospicetify:mainfrom
romdotdog:main

Conversation

@romdotdog
Copy link
Contributor

@romdotdog romdotdog commented Feb 20, 2026

Needs platform check

Summary by CodeRabbit

  • Bug Fixes
    • Improved stability of platform API initialization by adding an OS-specific guard to avoid resolving an incompatible API on Linux, while preserving existing resolution behavior and logging on other platforms.
    • No changes to public/exported interfaces.

@coderabbitai
Copy link

coderabbitai bot commented Feb 20, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

addMissingPlatformAPIs now detects the OS and skips resolving the ExclusiveModeAPI when running on Linux; all other platform API resolution logic, guards, and logging are unchanged.

Changes

Cohort / File(s) Summary
API Resolution Logic
jsHelper/spicetifyWrapper.js
Add local os detection and a guard to skip resolving ExclusiveModeAPI on Linux within addMissingPlatformAPIs; other guards and logs remain the same.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A hop, a check, a tiny tweak,
Linux nods — ExclusiveMode takes a break,
Code hums along, neat and spry,
Registry watches as changes fly. 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: skipping ExclusiveModeAPI resolution specifically to prevent a Linux segmentation fault, which matches the implementation that adds a Linux-specific guard.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@romdotdog romdotdog changed the title Skip ExclusiveModeAPI resolution to prevent Linux segfault fix: skip ExclusiveModeAPI resolution to prevent Linux segfault Feb 20, 2026
@rxri
Copy link
Member

rxri commented Feb 20, 2026

-.- lossless related feature doing bugs niceu, we should get operatingSystem from Spicetify.Platform and check if it's Linux and only disable it for this platform

@rxri rxri merged commit 5a6b235 into spicetify:main Feb 20, 2026
6 of 7 checks passed
@rxri
Copy link
Member

rxri commented Feb 20, 2026

ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants