-
-
Notifications
You must be signed in to change notification settings - Fork 7
Disable restart controller #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| ..StatefulSetSpec::default() | ||
| }; | ||
|
|
||
| let sts_metadata = metadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could leave this code in (commented).
At the very least IMHO we should add a TODO pointing to the issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about it, but its not much change/revert. I removed the enable part from changelog as well. I think we should rather untick HDFS in the restarter epic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds like a good idea
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Description
fixes #750
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker