Open
Conversation
b7652f1 to
ff65507
Compare
79259ec to
38d09d7
Compare
Changes the conditional to search for 'Intel' in the ansible_facts.processor variable as the first item in the list is not always consistent.
38d09d7 to
08d611f
Compare
technowhizz
commented
May 3, 2024
roles/iommu/tasks/main.yml
Outdated
| kernel_cmdline: "{{ ['intel_iommu=on'] }}" # noqa: var-naming[no-role-prefix] | ||
| kernel_cmdline_remove: # noqa: var-naming[no-role-prefix] | ||
| - ^intel_iommu= | ||
| - ^vfio-pci\.ids= |
Author
There was a problem hiding this comment.
shouldn't we also remove this?
jovial
reviewed
Jul 9, 2024
| @@ -0,0 +1,20 @@ | |||
| --- | |||
| - name: Regenerate initramfs (RedHat) | |||
Collaborator
There was a problem hiding this comment.
This seemed to run after the reboot handler
Co-authored-by: Dawud <7688823+technowhizz@users.noreply.github.com>
cityofships
reviewed
Aug 5, 2024
| # but it can help with dmesg spam in newer kernels (centos8?). Sample | ||
| # dmesg log message: | ||
| # [ +0.000002] kvm [8348]: vcpu0, guest rIP: 0xffffffffb0a767fa ignored rdmsr: 0x619 | ||
| # options kvm report_ignored_msrs=N |
Member
There was a problem hiding this comment.
Maybe should uncomment by default
priteau
requested changes
Aug 27, 2024
| ansible.builtin.blockinfile: | ||
| path: /etc/dracut.conf.d/gpu-vfio.conf | ||
| block: | | ||
| add_drivers+="vfio vfio_iommu_type1 vfio_pci vfio_virqfd" |
Member
There was a problem hiding this comment.
I saw warnings about this configuration:
2024-08-27T12:52:11+0000 INFO /etc/dracut.conf.d/gpu-vfio.conf:add_drivers+="vfio vfio_iommu_type1 vfio_pci vfio_virqfd"
dracut: WARNING: <key>+=" <values> ": <values> should have surrounding white spaces!
dracut: WARNING: This will lead to unwanted side effects! Please fix the configuration file.
dracut-install: Failed to find module 'vfio_virqfd'
dracut: FAILED: /usr/lib/dracut/dracut-install -D /var/tmp/dracut.kNu52l/initramfs --kerneldir /lib/modules/5.14.0-362.24.1.el9_3.0.1.x86_64/ -m vfio vfio_iommu_type1 vfio_pci vfio_virqfd
/etc/dracut.conf.d/gpu-vfio.conf:add_drivers+="vfio vfio_iommu_type1 vfio_pci vfio_virqfd"
dracut: WARNING: <key>+=" <values> ": <values> should have surrounding white spaces!
dracut: WARNING: This will lead to unwanted side effects! Please fix the configuration file.
dracut-install: Failed to find module 'vfio_virqfd'
dracut: FAILED: /usr/lib/dracut/dracut-install -D /var/tmp/dracut.gebJKd/initramfs --kerneldir /lib/modules/5.14.0-362.24.1.el9_3.0.1.x86_64/ -m vfio vfio_iommu_type1 vfio_pci vfio_virqfd
Please fix the syntax.
Collaborator
|
My plan to make it work well with vgpus (so we can mix passthrough and vpgu):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs to merge after #21