Resolve temp dir to real path in skills and installer unit tests

[reyortiz3]

Resolve temp dir to real path in skills tests

The edits make tests use the resolved temporary directory path (no symlinks) instead of whatever t.TempDir() returns.

1. pkg/skills/installer_test.go

• TestExtract: Replaces t.TempDir() with filepath.EvalSymlinks(t.TempDir()) so targetDir is under the real path.
• TestExtract_PermissionsSanitized: Same pattern for the perms test’s targetDir.

2. pkg/skills/skillsvc/skillsvc_test.go

• New helper tempDir(t): returns filepath.EvalSymlinks(t.TempDir()), marked with t.Helper().
• All temp dir usage in that file is switched to tempDir(t) (or filepath.Join(tempDir(t), ...)) instead of t.TempDir() in:
  • TestInstallWithExtraction (several cases)
  • TestInstallFromOCI (OCI store dirs, skill dirs, target dirs)

Why this helps

On macOS, the default temp dir often goes through a symlink (e.g. /var/folders/... → /private/var/folders/...), therefore, installer_test and skillssvc_test failing on macOS with:

extracting skill: target path validation: symlink found at "/var": refusing to extract through symlinks

If tests pass a symlinked path but the code under test (or libraries like the OCI store) resolve paths to their real location, you can get:

• Path comparison mismatches
• “Path not found” or wrong working dir
• Flaky or environment-dependent failures
  Using filepath.EvalSymlinks(t.TempDir()) (and the shared tempDir(t) helper) makes tests use the same canonical path the rest of the code sees, which stabilizes these tests on systems where the temp dir is a symlink.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.69%. Comparing base (7095e8e) to head (7e437c9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3928      +/-   ##
==========================================
+ Coverage   67.63%   67.69%   +0.06%     
==========================================
  Files         438      438              
  Lines       44108    44108              
==========================================
+ Hits        29833    29860      +27     
+ Misses      11939    11912      -27     
  Partials     2336     2336              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.