Skip to content

chore(ui): Fix remaining lint issues for PF6 migration#19212

Merged
dvail merged 16 commits intodv/ROX-28622-pf-6from
dv/pf6-lint-fixes
Feb 26, 2026
Merged

chore(ui): Fix remaining lint issues for PF6 migration#19212
dvail merged 16 commits intodv/ROX-28622-pf-6from
dv/pf6-lint-fixes

Conversation

@dvail
Copy link
Contributor

@dvail dvail commented Feb 26, 2026

Description

Fixes remaining errors detected by npm run lint that are not handled in other recently merged PRs.

  1. Replace instances of --pf-v5- with --pf-v6- equivalent
  2. Remove a few overrides to PatternFly styling that moved us further away from the defaults (and not for the purpose of coexisting with Tailwind)
  3. Replace <DescriptionListCompact> with <DescriptionList isCompact> and fix an issue with PF6 termWidth prop

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Manual testing.

Before termWidth:
image

After with horizontalTermWidthModifier (and banner color fixes):
image

@dvail
Copy link
Contributor Author

dvail commented Feb 26, 2026

This change is part of the following stack:

Change managed by git-spice.

@openshift-ci
Copy link

openshift-ci bot commented Feb 26, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dvail dvail marked this pull request as ready for review February 26, 2026 14:07
@dvail dvail requested a review from a team as a code owner February 26, 2026 14:07
@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.52%. Comparing base (de1e05a) to head (5e07be4).
⚠️ Report is 3 commits behind head on dv/ROX-28622-pf-6.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           dv/ROX-28622-pf-6   #19212      +/-   ##
=====================================================
- Coverage              49.52%   49.52%   -0.01%     
=====================================================
  Files                   2666     2666              
  Lines                 201181   201181              
=====================================================
- Hits                   99632    99629       -3     
- Misses                 94113    94116       +3     
  Partials                7436     7436              
Flag Coverage Δ
go-unit-tests 49.52% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@pedrottimark pedrottimark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tenacity and attention to detail.

@dvail dvail merged commit 063e33c into dv/ROX-28622-pf-6 Feb 26, 2026
128 of 147 checks passed
@dvail dvail deleted the dv/pf6-lint-fixes branch February 26, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants