chore(ui): Fix remaining lint issues for PF6 migration#19212
Merged
dvail merged 16 commits intodv/ROX-28622-pf-6from Feb 26, 2026
Merged
chore(ui): Fix remaining lint issues for PF6 migration#19212dvail merged 16 commits intodv/ROX-28622-pf-6from
dvail merged 16 commits intodv/ROX-28622-pf-6from
Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
dvail
commented
Feb 26, 2026
ui/apps/platform/src/Components/DescriptionListCompact/DescriptionListCompact.tsx
Show resolved
Hide resolved
dvail
commented
Feb 26, 2026
ui/apps/platform/src/Containers/AccessControl/AccessScopes/AccessScopeForm.tsx
Show resolved
Hide resolved
dvail
commented
Feb 26, 2026
ui/apps/platform/src/Containers/NetworkGraph/components/LegendContent.tsx
Show resolved
Hide resolved
dvail
commented
Feb 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dv/ROX-28622-pf-6 #19212 +/- ##
=====================================================
- Coverage 49.52% 49.52% -0.01%
=====================================================
Files 2666 2666
Lines 201181 201181
=====================================================
- Hits 99632 99629 -3
- Misses 94113 94116 +3
Partials 7436 7436
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pedrottimark
approved these changes
Feb 26, 2026
Contributor
pedrottimark
left a comment
There was a problem hiding this comment.
Thank you for tenacity and attention to detail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes remaining errors detected by
npm run lintthat are not handled in other recently merged PRs.--pf-v5-with--pf-v6-equivalent<DescriptionListCompact>with<DescriptionList isCompact>and fix an issue with PF6termWidthpropUser-facing documentation
Testing and quality
Automated testing
How I validated my change
Manual testing.
Before

termWidth:After with

horizontalTermWidthModifier(and banner color fixes):