Skip to content

Fixed type hint for patch_signals #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicobako wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fixed type hint for patch_signals #36

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2cf8ade
Fixed type hint for patch_signals
nicobako Mar 10, 2026
d4e321c
Added more json-encodable types
nicobako Mar 10, 2026
f363e42
Added bool
nicobako Mar 10, 2026
f0b3a9a
Use SignalValue as type hint instead
nicobako Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/datastar_py/sse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from typing import Literal, Protocol, TypeAlias, overload, runtime_checkable

import datastar_py.consts as consts
from datastar_py.attributes import _escape
from datastar_py.attributes import _escape, SignalValue

SSE_HEADERS: dict[str, str] = {
"Cache-Control": "no-cache",
Expand Down Expand Up @@ -136,7 +136,7 @@ def remove_elements(
@classmethod
def patch_signals(
cls,
signals: dict | str,
signals: dict[str, SignalValue] | str,
event_id: str | None = None,
only_if_missing: bool | None = None,
retry_duration: int | None = None,
Expand Down
Loading