Skip to content

fix: make column drops succeed if missing #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adthrasher merged 1 commit into from
Mar 18, 2026
Merged

fix: make column drops succeed if missing #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dx_app/resources/stjude/bin/generate_plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ def label_samples (row):
combined['highlight'] = combined.apply(lambda row: label_samples(row), axis=1)

# Drop unneeded columns
combined = combined.drop(columns=["id", "name", "folder", "sj_access_unit", "sj_dataset_accessions", "sj_pmid_accessions", "file_type", "sj_embargo_date", "sj_pipeline_name", "sj_pipeline_version", "sj_pub_accessions", "sj_publication_titles", "projects"])
combined = combined.drop(columns=["sj_disease"])
combined = combined.drop(columns=["id", "name", "folder", "sj_access_unit", "sj_dataset_accessions", "sj_pmid_accessions", "file_type", "sj_embargo_date", "sj_pipeline_name", "sj_pipeline_version", "sj_pub_accessions", "sj_publication_titles", "projects"], errors="ignore")
combined = combined.drop(columns=["sj_disease"], errors="ignore")

# Copy user submitted sample names to the standard 'sample_name' column
combined['sample_name'] = combined['sample_name'].fillna(combined['samples'])
Expand All @@ -88,7 +88,7 @@ def label_samples (row):
#combined = combined.rename(columns={"sj_long_disease_name_x": "sj_long_disease_name"})

# Drop unneeded columns
combined = combined.drop(columns=["samples", "classes", "diagnosisNames"])
combined = combined.drop(columns=["samples", "classes", "diagnosisNames"], errors="ignore")

# Fill group in a way to avoid duplicates
combined['group'] = combined['group'].fillna('Other ' + combined['attr_diagnosis_group'])
Expand Down
Loading