fix: propagate tool exceptions to spans so StatusCode.ERROR is set correctly#2046
Open
mattdai01 wants to merge 1 commit intostrands-agents:mainfrom
Open
fix: propagate tool exceptions to spans so StatusCode.ERROR is set correctly#2046mattdai01 wants to merge 1 commit intostrands-agents:mainfrom
mattdai01 wants to merge 1 commit intostrands-agents:mainfrom
Conversation
…rrectly When a tool fails, the exception was being dropped before reaching end_tool_call_span, causing all tool spans to get StatusCode.OK even on errors. This threads the original exception through ToolResultEvent yields and into the tracer, and creates exceptions for cancel/unknown tool paths that previously had none. Fixes strands-agents#2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a tool fails, the exception was being dropped before reaching end_tool_call_span, causing all tool spans to get StatusCode.OK even on errors. This threads the original exception through ToolResultEvent yields and into the tracer, and creates exceptions for cancel/unknown tool paths that previously had none.
Fixes #2016
Description
When a tool raises an exception, Strands catches it and converts it to a
ToolResultdict withstatus='error'. The original exception object was dropped at theToolResultEventyield points in_executor.py, soend_tool_call_spannever received it and always setStatusCode.OK. This breaks observability backends like Langfuse that rely on span status codes for error detection.This PR fixes the root cause by:
ToolResultEventyields and intoend_tool_call_spanso tool spans correctly getStatusCode.ERRORstatus: "error"results without an exception objectPR #2027 proposed synthesizing an
Exceptionfrom error text intracer.py. This PR instead fixes the root cause — the exception was already available but simply not threaded through. This preserves the original exception type and traceback.Related Issues
Fixes #2016
Documentation PR
N/A
Type of Change
Bug fix
Testing
hatch run preparetest_end_tool_call_span_with_error— explicit error setsStatusCode.ERRORandrecord_exceptiontest_executor_stream_with_trace_error— exception flows from tool to tracertest_executor_stream_error_preserves_exception—ToolResultEvent.exceptionis settest_executor_stream_unknown_tool_has_exception— unknown tool pathtest_executor_stream_cancel_has_exception— cancel pathChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.