Fix unsafe rm in testStrataCommand.sh: remove unnecessary glob and quote variable#455
Open
tautschnig wants to merge 2 commits intomainfrom
Open
Fix unsafe rm in testStrataCommand.sh: remove unnecessary glob and quote variable#455tautschnig wants to merge 2 commits intomainfrom
tautschnig wants to merge 2 commits intomainfrom
Conversation
…ote variable
The cleanup function used 'rm -R ${temp_dir}*' which would expand to
'rm -R *' if temp_dir were ever empty, deleting the current directory's
contents. Since all temporary files are created inside the mktemp
directory, the glob is unnecessary. Removed it and quoted the variable.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical security vulnerability in the cleanup function of the Strata command test script. The original code used an unquoted variable with a glob pattern that could catastrophically delete the current directory's contents if the temp_dir variable were empty.
Changes:
- Fixed unsafe
rm -R ${temp_dir}*by removing the glob and properly quoting the variable asrm -R "${temp_dir}"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cleanup function used 'rm -R ${temp_dir}*' which would expand to 'rm -R *' if temp_dir were ever empty, deleting the current directory's contents. Since all temporary files are created inside the mktemp directory, the glob is unnecessary. Removed it and quoted the variable.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.