-
Notifications
You must be signed in to change notification settings - Fork 0
Enable TAE-EP simulations (fix several bugs) #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bkna0327
wants to merge
214
commits into
devel
Choose a base branch
from
enable_tae
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
214 commits
Select commit
Hold shift + click to select a range
59169b5
add (the idea) of a new Variables class
spossann 1995b6c
add new folder topology/ with file grids.py
spossann b2e8de1
also search for .py files when scanning for parameters files
spossann aaab3bb
new files struphy/io/inp/parameters.py and strupyh/io/inp/options.py …
spossann b4872e7
use new class StruphyParameters to set up a Maxwell simulation
spossann c76a6e5
formatting
spossann a397d48
some cleanup
spossann eeecd24
new options class FieldsBackground
spossann 677c238
new classes `Variables` and `Variable` for handling model variables
spossann 0988014
new classes: `Species`, `MultiSpecies` and `SubSpeceis`; these will r…
spossann eb0fa98
belongs to previous commit
spossann 24b76bf
formatting and cleaning of new params file
spossann f248d02
a lot of tryout
spossann 3a0e587
add method `derive_units` to Units class; remove dataclass decorator
spossann ce3862a
add function `check_option` to options.py
spossann 9c97d94
finished light-weight init of models base class
spossann 3bcb924
add `set_phys_params` and `set_equation_params` to SubSpecies
spossann a0fec5a
remove @staticmethod from Model.bulk_species and Model.velocity_scale
spossann dad4961
add inner class Options to Propagator base
spossann 70f5349
new folder `physics`; holds the natural constants for the moment
spossann ece3f90
new files `propagators/hub.py` and `propagators/hub.pyi`; the Propaga…
spossann 0261be4
adapt Maxwell propagator
spossann bf78073
Object-oriented brainstorming
max-models ccdeaba
redo Species structure: FieldSpecies, FluidSpecies, KineticSpecies
spossann 629cc15
added new file models/variables.py
spossann 0fddf10
remove propagators/hub
spossann 2b7812b
working on struphy main.py
spossann b27e879
Added DiagnosticSpecies, added attribute variables to Species, added …
spossann 6d6a56a
added metohd allocate to FEECVariable
spossann 5d320ec
- new base class `Perturbation` in initial/base.py
spossann bf45fe7
perform initialize_coeffs in __init__ of SplineFunction when backgrou…
spossann 60e0d39
use given_in_basis in TransformedPformComponent; experiment with TYPE…
spossann 88d500d
put Literal options on top of options.py module
spossann 469a56b
do not allow dict input in setup parameters anymore (only file paths,…
spossann ae34596
make ButcherTableau a dataclass
spossann 7dfecfb
Propagator base class: add options attribute and setter; add Options …
spossann 1da7b0f
New design of Maxwell propagator:
spossann cd81285
StruphyModel base class: new methods allocate_feec, set_propagators a…
spossann 72528d1
added type annotation to FEECVariable declaration for better inferenc…
spossann 6aa641b
use new methods of model in main.py
spossann a3b9601
have a working light-weight .py parameter file for Maxwell
spossann e13bcaf
work on allocate of Maxwell propagator
spossann d2b2f56
added allocate_propagators and prop_list to StruphyModel
spossann ff2c5f1
improved Propagator.set_variables() method; make Maxwell toy model work
spossann bd7c452
Make coaxial test for Maxwell run
spossann 6a5e453
add function import_parameters_py; make pproc work with new params
spossann 6721f76
added params file Maxwell_coaxial.py for verification; made pproc wor…
spossann 11408b3
started fixing some unit tests
spossann 0445f62
- remove StruphyModel.setup()
spossann 6fdae08
LinearMHD model is running
spossann 7526d9a
new abstract method StruphyModel.allocate_helpers()
spossann 0c74a66
new generate_default_parameter_file for .py parameters
spossann c3bab8b
include call to struphy main in parameter file; new class MetaOptions
spossann 95b6e17
renam main.py -> struphy.py and main() -> run()
spossann b76d94e
rename MetaOptions -> EnvironmentOptions
spossann ad4f3fe
New framework for model tests:
spossann 78a3578
delete StruphyParameters
spossann c138e26
allow pickling parameter objects when no params_path is given
spossann 419be1d
pickle of compiled domain doesnt work
spossann 2198811
implement work-around for pickling domain
spossann 02541ef
new function `load_data` in main.py; added fitting to power_spectrum_…
spossann f96f77b
clean up screen output and maxwell test
spossann 92616fc
nicer screen output, inidicate code sections
spossann 186545c
make test_maxwell a pytest
spossann 5d78795
add coaxial test to test_maxwell
spossann 66d78b1
make __init__ an abstract method of StruphyModel; require 3 ranks for…
spossann 8e79ab8
new test test_LinearMHD.py is working
spossann bfca873
refactor `struphy params`, use getcwd()/params_MODEL.py as default path
spossann 7b1d548
new file models/tests/test_models.py for generic testing
spossann 2bd1a87
minor changes
spossann bb41fa9
generate specific default parameter file for LinearMHD
spossann d07d716
adapt marler propagators PushEta and PushVxB
spossann 02346a3
adapt toy model VLasov
spossann 6f4316f
work on the allocate() method for PICVariable
spossann 86ad116
work on storing pic data
spossann 4f9ec66
Re-factor Maxwllian3D and base class:
spossann c534984
set background in Particles according to new framework - no dicts, bu…
spossann b23593e
remove some unneccessary imports
spossann e24278e
re-factor marker paramter passing
spossann 8b3cae3
Vlasov is running
spossann 1b27f67
default parameters for kinetic species
spossann 4e3b264
new class BoundaryParameters for particles; start working on Tutorial 01
spossann e0b292c
started new particels tutorial
spossann 397282c
new way of saving during pproc
spossann 7930d7d
new tutorial 01: parameter files
spossann 24bd43c
improve tutorial 01
spossann 9b151a9
improve tutorial 01 more
spossann b1b93c3
finish tutorial 01
spossann 7ea7aee
- get rid of @dataclass for Species
spossann aca8c91
improve tutorial 02
spossann 9e05ede
remove "as Model" in params file
spossann fc8b841
improve tutorials 1 and 2
spossann 746370e
minor
spossann 474e87b
* Refactor Domain base class:
spossann d0a3460
adapted GVECunit
spossann 7e9e980
use locals() to get parameter dict; adapt some more mappings
spossann d306f50
adapt rest of mappings
spossann e81a899
replace Domain.params_map -> Domain.params
spossann 5eca46c
fix unit tests
spossann 390f62c
use same params.setter structure in equils as in domains (remove meth…
spossann 994413e
formatting
spossann 5728e79
Merge branch '458-store-domain-input-paramaters-unchanged' into 318-p…
spossann 250ed36
tutorial 2 works up to GuidingCenter
spossann 702fc95
Introduce SimData.orbits and SimData.spline_values
spossann 9e99367
repair Maxwell and LinearMHD tests
spossann bdcaa7f
Two new abstract methods for Propagator:
spossann 56e3c9c
New way of setting Propagator options through three abstract
spossann dc05b3a
adapt LinearMHD to new options setting
spossann 00a9c5c
adapt Vlasov to new options
spossann ab21da6
make toy model GuidingCenter run in new framework
spossann 6694072
tutorial 2 on test particles is now complete and running. Adaption of…
spossann ff45240
started to transfer model VlasovAmpereOneSpecies
spossann aaa58fd
VlasovAmpereOneSecies is running
spossann 32baaf2
new class BinningPlot
spossann f270e5a
added Simdata.f dict for distribution function
spossann bc1cdc3
new method Maxwellian.add_perturbation enables to extract the backgro…
spossann 72c59ce
fix bug in initial Poisson solve of VlasovAmpereOneSpecies; add flaf …
spossann ab85525
add line_profiler to some functions
spossann ef3ba9d
fix base_units loading; allow comm=None in Particles
spossann f2a403f
added tutorial 5
spossann 508445f
Format all source files and and temporary linting check to CI
max-models 745b2d2
Merge branch 'format-all-files' into '318-parameter-file-as-py'
spossann 8302d5d
Move tutorials to base folder
max-models e014b9c
Merge branch 'move-tutorials-to-base-folder' into '318-parameter-file…
spossann 3faca93
Fix unit testing
spossann 0691aae
Merge branch 'fix-unit-testing' into '318-parameter-file-as-py'
spossann af3668b
Resolve "Port toy model PressurelessSPH to 318"
spossann f557c92
Merge branch '460-port-toy-model-pressurelesssph-to-318' into '318-pa…
spossann 0f8f5e2
Port sph tutorial to 318
spossann 33b8e76
Merge branch 'port-sph-tutorial-to-318' into '318-parameter-file-as-py'
spossann d3d46ca
Recent updates from devel into 318
spossann 44dfc2e
Merge branch 'merge-devel-1-10-25' into '318-parameter-file-as-py'
spossann 649eb92
Updated __init__.py files in 318
max-models 60dbc08
Merge branch 'update-init-files' into '318-parameter-file-as-py'
spossann 1952c26
Add SPH and VlasovAmpere verification tests
spossann d00e7ea
Merge branch 'verif-tests-porting' into '318-parameter-file-as-py'
spossann 797f3d8
Resolve "Port some toy models to 318"
spossann 3974ada
Merge branch '461-port-some-toy-models-to-318' into '318-parameter-fi…
spossann ab43c4a
Merge branch 'devel' into merge-devel-8-10-25
spossann b5754f0
remove double --check-file
spossann 9f5701d
Update shearalfven to new format
max-models 5ee5a56
Merge branch 'update-shearalfven-to-new-format' into '318-parameter-f…
spossann fd2a463
test hook
spossann 4c77173
update pre-commit yaml
spossann 16ae146
test pre-commit hooks
spossann b1343de
try hook option --assume-in-merge
spossann fc42259
test hook
spossann efc0fc1
remove merge conflicts
spossann b75d347
Resolve "Port remaining toy models"
spossann d3a073f
Merge branch '465-port-remaining-toy-models' into '318-parameter-file…
spossann bd9e618
Merge branch '318-parameter-file-as-py' into merge-devel-8-10-25
spossann c56a8d4
Merge branch 'merge-devel-8-10-25' into '318-parameter-file-as-py'
spossann 1bc3a8d
Ported three fluid models
spossann 7e516ee
Merge branch 'port-three-fluid-models' into '318-parameter-file-as-py'
spossann 433d54b
Porting the model LinearMHDDriftkineticCC
bkna0327 da064e6
Merge branch '318-parameter-file-as-py-mhd-driftkinetic' into '318-pa…
spossann 3c6a268
Added `--oversubscribe` to the test mpirun commands
max-models 4f6d91e
Merge branch 'run-318-tests-with-oversubscribe' into '318-parameter-f…
spossann 408932f
enable TAE sims
239822b
fix bug
4f6eccc
fix bug
bkna0327 f41eb71
Resolve "Porting the rest of fluid models"
spossann 223bdf4
Merge branch '469-porting-the-rest-of-fluid-models' into '318-paramet…
spossann 2b8dbf8
Merge branch 'devel' into merge-devel-21-10-2025
spossann 6e9ce14
re-add model_tests_mpi
spossann 353d692
remove test_tutorials.py again
spossann ac598e3
add new mpi and xp to species.py
spossann 7be337d
add mpi and xp to some new files which do not exist in devel
spossann 9d92d1f
add new mpi to new models files
spossann 0e764a7
add missing Pyccelkernel
spossann 0a85779
check for MockMPI in StruphyModel
spossann 9d08cd5
remove deprecated --verification flag from tests
spossann 74c5e06
formatting
spossann 77fd7e4
test an already ported model for the single test
spossann 111775d
use Barrier() in main.py
spossann 533223c
fix verification test
spossann 06e86f4
fix gyrokinetic_poisson
spossann 613cd58
formatting
spossann 21815d6
Merge branch 'merge-devel-21-10-2025' into '318-parameter-file-as-py'
spossann 26fc52e
Resolve "Rename struphy array imports to xp"
max-models c76e68e
Merge branch '470-rename-struphy-array-imports-to-xp-3' into '318-par…
spossann 5eac499
Resolve "Porting the rest of kinetic models"
spossann 3241341
Merge branch '471-porting-the-rest-of-kinetic-models' into '318-param…
spossann 6b6163c
Use cunumpy
max-models 93263f8
Merge branch 'use-cunumpy' into '318-parameter-file-as-py'
spossann ac71d97
minor fixes
db8623c
Update tutorials
spossann 50a689b
Merge branch 'update-tutorials' into '318-parameter-file-as-py'
spossann 6452078
Added struphy[mpi] to [dev] dependencies
max-models b2afd19
Port two hybrid
spossann cf91a74
Merge branch 'port-two-hybrid' into '318-parameter-file-as-py'
spossann 5a3d7c5
Merge branch 'install-mpi4pi-with-dev' into '318-parameter-file-as-py'
spossann 670539f
merging with the main branch
0bd4bb6
bug fix
f52925e
bug fix
0485d8e
bug fix
1c99ebc
enable restart
3cdbc6b
remove barrier at main.py
f9934db
merging with devel
0925408
merging with devel
a144c08
merging with devel
0378cc5
merging with devel final
2899091
set default boxes_per_dim None
fa2327a
format
524a109
fix piplines
95feee4
fix piplines
51fd949
Merge branch 'devel' into enable_tae
8c2fef1
fix pipline
f2dd7f4
resolving comments
bbabb86
formatting
334f514
Merge branch 'devel' into enable_tae
92e7734
rename psic_to_eta as psic_to_rc
36fc8fe
pass the argument n_col_... to the base class
6db7bb6
consistent input arguments for CanonicalMaxwellian
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -176,4 +176,4 @@ markers = [ | |
| "kinetic", | ||
| "hybrid", | ||
| "single", | ||
| ] | ||
| ] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it is not clear whether one evaluates at
etaor atpsic. I would opt foretafor consistency.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently,$\varepsilon$ .
argsincludes the canonical toroidal momentumpsicand the energy