Set logger in struphy __init__.py#219
Draft
spossann wants to merge 4 commits intouse-logging-instead-of-printfrom
Draft
Set logger in struphy __init__.py#219spossann wants to merge 4 commits intouse-logging-instead-of-printfrom
spossann wants to merge 4 commits intouse-logging-instead-of-printfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR goes into
use-logging-instead-of-print, see #199I read that the logger should be set up at the beginning of the entry point of the program. Since we do not have a clear entry point, the best thing is to maybe setup in the struphy
__init__.py.__init__.pyset_logger_levelto set the level of all handlersThe function
set_logger_levelcan be tested withpython src/struphy/utils/utils.py.I set the default level to
logging.WARNING.