Merged
Conversation
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
There was a problem hiding this comment.
Pull request overview
Fixes multipart/form-data upload error handling so that storage-layer validation errors (notably invalid/unsupported MIME types) are not incorrectly wrapped as “No content provided”, aligning multipart behavior with the binary upload path.
Changes:
- In
fileUploadFromRequest, rethrowStorageBackendErrorfrom the multipart parsing/validation block instead of wrapping it inERRORS.NoContentProvided. - Add an integration test case to cover disallowed MIME type handling specifically when
contentTypeis provided via multipart form fields. - Clarify the existing MIME validation test name to indicate it exercises the “binary path”.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/storage/uploader.ts |
Ensures multipart parsing/validation bubbles StorageBackendError (e.g., invalid MIME type) rather than masking it. |
src/test/object.test.ts |
Adds coverage for multipart contentType field MIME validation and renames the existing “binary path” test for clarity. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report for CI Build 24181940260Coverage increased (+0.007%) to 80.826%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
fenos
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Multipart form-data upload path doesn't bubble errors correctly.
For example, there is a mime error thrown, it will be caught and converted to size error.
What is the new behavior?
Bubble the error if storage error immediately otherwise fallback.