fix(gotrue): replace assert with AuthException for PKCE asyncStorage check#1349
Open
sanadidari wants to merge 1 commit intosupabase:mainfrom
Open
fix(gotrue): replace assert with AuthException for PKCE asyncStorage check#1349sanadidari wants to merge 1 commit intosupabase:mainfrom
sanadidari wants to merge 1 commit intosupabase:mainfrom
Conversation
…check Added error handling for missing OAuth URL and updated PKCE flow storage check.
Collaborator
|
I think a better solution for this is to add an assert statement in the constructor of the gotrue client. But that is a breaking change and therefore add it in v3 #1278 of the library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1319
Problem
When
flowTypeisAuthFlowType.pkce(the default) and noasyncStorageis provided, calling
getOAuthSignInUrl()orgetLinkIdentityUrl()crashesin release mode with a cryptic
Null check operator used on a null valueerror. The existing
assert()only runs in debug builds and is silentlystripped in release.
Changes
_getUrlForProvider: replaceassert+_asyncStorage!with an explicitnull check that throws a descriptive
AuthExceptionin all build modes.getLinkIdentityUrl: add null check onres['url']before casting,throwing a descriptive
AuthExceptionif the provider returns no URL.Before / After