Make Ruby sdkbuild BaseDir consistent with Python/TS#780
Merged
Conversation
Previously, BuildRubyProgram hardcoded `sourceDir = BaseDir + "/harness/ruby"`, requiring callers to pass a parent directory as BaseDir. This was inconsistent with Python and TypeScript where BaseDir IS the source directory containing the project files. Now BaseDir points directly to the directory containing the gemspec and runner.rb, and RubyProgramFromDir derives the source from the parent of the build dir. Callers (run_ruby.go, run.go) updated to pass `harness/ruby` as BaseDir. This enables other repos (e.g. omes) to use BuildRubyProgram with their own directory layout without needing a `harness/ruby` subdirectory.
THardy98
force-pushed
the
fix/sdkbuild-ruby-basedir
branch
from
513906c to
c733645
Compare
Sushisource
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, BuildRubyProgram hardcoded
sourceDir = BaseDir + "/harness/ruby", requiring callers to pass a parent directory as BaseDir. This was inconsistent with Python and TypeScript where BaseDir IS the source directory containing the project files.Now BaseDir points directly to the directory containing the gemspec and runner.rb, and RubyProgramFromDir derives the source from the parent of the build dir. Callers (run_ruby.go, run.go) updated to pass
harness/rubyas BaseDir.This enables other repos (e.g. omes) to use BuildRubyProgram with their own directory layout without needing a
harness/rubysubdirectory.