Skip to content

Add note about Rosetta for old protoc-gen-rpc-java#2815

Merged
eamsden merged 1 commit intomasterfrom
protoc-gen-rpc-java-rosetta-trap
Mar 24, 2026
Merged

Add note about Rosetta for old protoc-gen-rpc-java#2815
eamsden merged 1 commit intomasterfrom
protoc-gen-rpc-java-rosetta-trap

Conversation

@eamsden
Copy link
Contributor

@eamsden eamsden commented Mar 24, 2026

What was changed

  • Added notes about Rosetta to CONTRIBUTING.md
  • Added comments explaining backward-looking conditionals around protoc-gen-rpc-java executable selection in gradle files

Why?

I tripped over newer MacOS not installing Rosetta by default when we were silently relying on that to cover for the version of protoc-gen-rpc-java not shipping MacOS aarch64 binaries. I'm adding a note to CONTRIBUTING.md and comments in the relevant gradle files so other developers have some hope of not falling down the same rabbit hole I did.

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

I tripped over newer MacOS not installing Rosetta by default when we
were silently relying on that to cover for the version of
protoc-gen-rpc-java not shipping MacOS aarch64 binaries. I'm adding a
note to CONTRIBUTING.md and comments in the relevant gradle files so
other developers have some hope of not falling down the same rabbit hole
I did.
@eamsden eamsden requested a review from a team as a code owner March 24, 2026 19:21
@eamsden eamsden merged commit b9c186d into master Mar 24, 2026
17 checks passed
@eamsden eamsden deleted the protoc-gen-rpc-java-rosetta-trap branch March 24, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants