Open
Conversation
|
|
…ross-ref, misleading comment
trevoryao
force-pushed
the
fix/python-reference-bugs
branch
from
068cd91 to
38300fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three bugs in the Python SDK reference documents:
references/python/determinism.md: Changedworkflow.new_random()toworkflow.random()in the safe alternatives table. The correct API isworkflow.random(), which is also used correctly in the best practices section of the same file.references/python/testing.md: Removed theworkflow_id=keyword argument inWorkflowHistory.from_json(workflow_id=str(uuid.uuid4()), history_json). This is a Python syntax error — a keyword argument cannot precede a positional argument. The first parameter is positional (workflow_id), so it should be passed without the keyword when followed by a positionalhistory_json.references/python/ai-patterns.md: Fixed cross-reference fromreferences/core/ai-integration.mdtoreferences/core/ai-patterns.md, which is the file that actually exists.