fix: migrate kube-rbac-proxy image from deprecated gcr.io to registry.k8s.io#219
fix: migrate kube-rbac-proxy image from deprecated gcr.io to registry.k8s.io#219amit-darji wants to merge 1 commit intotemporalio:mainfrom
Conversation
|
|
|
@amit-darji |
|
@gabriel-yahav, yes we will do a release once this is fixed! Sorry this slipped through the cracks. I also added a new CI check to make sure image-pull errors won't happen again with this chart. @amit-darji I can merge this as soon as you sign the CLA |
|
thanks for fixing! |
|
Thanks for fixing it! |
|
Thank you, I have the same |
|
@amit-darji - would be awesome if you can sign the CLA! we would love to get this in before @carlydf's #222 gets in! |
<!--- Note to EXTERNAL Contributors --> <!-- Thanks for opening a PR! If it is a significant code change, please **make sure there is an open issue** for this. We work best with you when we have accepted the idea first before you code. --> <!--- For ALL Contributors 👇 --> ## What was changed Uses crane to verify all container image references rendered by the Helm chart exist in their registries, catching broken or deprecated registry paths (e.g. gcr.io deprecation) on every PR and weekly. ## Why? We missed an un-pullable image (maintainer changed the image registry) which needed to be fixed by #219 . Don't want that to happen again ## Checklist <!--- add/delete as needed ---> 1. Closes <!-- add issue number here --> 2. How was this tested: <!--- Please describe how you tested your changes/how we can test them --> 3. Any docs updates needed? <!--- update README if applicable or point out where to update docs.temporal.io --> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
What was changed
Updated the kube-rbac-proxy sidecar image reference in the Helm chart from:
to:
Why?
The gcr.io registry is being discontinued. The kube-rbac-proxy project has officially announced the deprecation of
gcr.io/kubebuilder/kube-rbac-proxyin favour ofregistry.k8s.io— the community-maintained Kubernetes image registry.Continuing to use the old registry risks image pull failures on new installs or pod restarts once the registry is fully decommissioned, leading to silent deployment breakages.
Ref: https://github.com/kubernetes-sigs/kubebuilder/blob/master/designs/discontinue_usage_of_kube_rbac_proxy.md
Checklist
Closes
How was this tested: